Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Rename developer guide to contributor guide #609

Closed
wants to merge 2 commits into from
Closed

Docs: Rename developer guide to contributor guide #609

wants to merge 2 commits into from

Conversation

kjswalls
Copy link
Contributor

@kjswalls kjswalls commented Oct 28, 2017

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Close #272 in the sonarwhal.com repo
There's an open issue (#272) in the sonarwhal.com repo to change the name of the Developer Guide to the Contributor Guide, but because the npm run build script in that repo pulls the latest docs from this repo, the actual title and content of the guide page won't get changed until the docs are updated here as well. I've opened a corresponding pull request in the sonarwhal.com repo to fix this.

Let me know if my understanding is incorrect.

@alrra
Copy link
Contributor

alrra commented Oct 29, 2017

@kjswalls Thank you so much for this, we sincerely appreciate it!

npm run build script in that repo pulls the latest docs from this repo
Let me know if my understanding is incorrect.

Yes.


Note: You missed some links, but don't worry, I'll take care of them before merging.


@kjswalls Also, congrats on your first contribution to the sonar project! 🎉

@alrra alrra closed this in 400f5b5 Oct 29, 2017
alrra pushed a commit to webhintio/webhintio.github.io that referenced this pull request Oct 29, 2017
@alrra
Copy link
Contributor

alrra commented Oct 29, 2017

@kjswalls Your changes are now live: https://sonarwhal.com/docs/contributor-guide/ ^ ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge file-loader and misc
2 participants