Update AuditedCollection in order to respect Collection interface
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
ticket_308
branch
2 times, most recently
from
0061b76
to
c415142
Compare
phansys
changed the title
AuditedCollection in order to respect Collection interface
|
Now, this PR has 2 commits. First (835303a) just adds creates new instances of |
phansys
force-pushed
the
ticket_308
branch
3 times, most recently
from
770a364
to
630d329
Compare
|
Since I think you don't have enough time to review or make a deep analysis on this fix, I chose the 2nd option and squashed my commits. |
phansys
changed the title
AuditedCollection in order to respect Collection interfaceAuditedCollection in order to respect Collection interface
|
@tolry, could you please share your concerns or any feedback about this? Thank you in advance! |
|
Could you please rebase your PR and fix merge conflicts? |
phansys
force-pushed
the
ticket_308
branch
2 times, most recently
from
e83a125
to
163acb4
Compare
phansys
changed the title
AuditedCollection in order to respect Collection interfaceAuditedCollection in order to respect Collection interface
…Collection` interface
VincentLanglet
approved these changes
Feb 16, 2021
wbloszyk
approved these changes
Feb 16, 2021
|
Thanks @phansys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Update
AuditedCollectionin order to respectCollectioninterface.I am targeting this branch, because these changes attempt to respect BC.
Closes #308.
Changelog