Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow php8 #350

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Allow php8 #350

merged 1 commit into from
Feb 12, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Feb 12, 2021

Changelog

### Added
- PHP 8 support

@VincentLanglet VincentLanglet merged commit 92998d7 into sonata-project:1.x Feb 12, 2021
@VincentLanglet VincentLanglet deleted the allowPhp8 branch February 12, 2021 22:50
@Yozhef
Copy link

Yozhef commented Feb 18, 2021

@VincentLanglet could you release a new release to unlock work with updates to the next sonata project, or tell me something to help speed up the process

@wbloszyk
Copy link
Member

@Yozhef for now we are working on sonata-project/dev-kit#1405 (comment) and I do not think we wants to make release before these works. We have to decide about do we wanna provide entity audit also as standalone library. Additionaly we have to check code with commits and update changelog.

For now You can use dev-1.x version.

@VincentLanglet
Copy link
Member Author

@Yozhef for now we are working on sonata-project/dev-kit#1405 (comment) and I do not think we wants to make release before these works. We have to decide about do we wanna provide entity audit also as standalone library. Additionaly we have to check code with commits and update changelog.

I disagree, we don't have to wait for this to release a new version. I think we can tag a new one now or soon.

@wbloszyk
Copy link
Member

Release mean code is stable. Previous system was working on merge. In some cases code are appered and desapper in next tag. We must check it and understand it correct or it is mistake. So I do not think tag it is good idea.

@VincentLanglet
Copy link
Member Author

VincentLanglet commented Feb 18, 2021

The branch 1.x is based on the branch 1.0.
The code of the branch 1.0.9 (the last release) was working so I don't see why it wouldn't work now.

Last release is: 5725eca
All the new commit are coming from us.
If you're saying that we can't release, you're saying that we broke the code, which I don't believe.

@wbloszyk
Copy link
Member

wbloszyk commented Feb 19, 2021

Look at #323 (comment)

This is comment for fix 5725eca

BTW
IMO We will be able to release it in this month. I do not wanna release bug like support for symfony/framework-bundle v5 when not existing Controller in this version is used in code.

@VincentLanglet
Copy link
Member Author

Look at #323 (comment)

This is comment for fix 5725eca

It's not because the test suite was broken that the bundle wasn't working. It was used a lot.
And the test suite is not broken anymore.
Even if it was broken, if we release a new version, it wouldn't be worse than the 1.0.9 one, so I see no reason to not doing it.

The only question should be, do we have introduce a bug since 1.0.9 ? I think not.

@wbloszyk
Copy link
Member

@Yozhef
https://github.com/sonata-project/EntityAuditBundle/releases/tag/1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants