Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Symfony 6 #439

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Add support for Symfony 6 #439

merged 4 commits into from
Sep 20, 2021

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Sep 19, 2021 •
edited
Loading

Subject

I am targeting this branch, because this is BC.

Part of: sonata-project/dev-kit#1675
Dev-kit PR: sonata-project/dev-kit#1684

Changelog

### Added
- Added explicit dependencies with Doctrine and Symfony.
- Added support for Symfony 6
### Removed
- Removed support for Symfony 5.2

@jordisala1991 jordisala1991 marked this pull request as ready for review September 19, 2021 07:18
@jordisala1991 jordisala1991 mentioned this pull request Sep 19, 2021
Merged
@jordisala1991 jordisala1991 requested a review from a team September 19, 2021 07:26
@jordisala1991 jordisala1991 changed the title Improve composer Add support for Symfony 6 Sep 19, 2021
@jordisala1991 jordisala1991 mentioned this pull request Sep 19, 2021
Closed
36 tasks
phansys
phansys reviewed Sep 19, 2021
View reviewed changes
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the "symfony/http-foundation" dependency, I think this should be optional, since this bundle can work without its controllers.

@jordisala1991
Copy link
Member Author

About the "symfony/http-foundation" dependency, I think this should be optional, since this bundle can work without its controllers.

Yep, I added it to require dev for that matter.

@phansys phansys requested a review from a team September 19, 2021 16:01
VincentLanglet
VincentLanglet reviewed Sep 20, 2021
View reviewed changes
src/Collection/AuditedCollection.php
@@ -105,6 +105,9 @@ public function __construct(AuditReader $auditReader, $class, ClassMetadataInfo
$this->entities = new ArrayCollection();
}

/**
* @return bool
Copy link
Member

@VincentLanglet VincentLanglet Sep 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we rely on interface phpdoc ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't add it here, you get deprecation from symfony. This way we silence it (and we know that at some point we will need to add it to the method directly without phpdoc.

@jordisala1991 jordisala1991 merged commit 46dd179 into sonata-project:1.x Sep 20, 2021
@jordisala1991 jordisala1991 deleted the hotfix/improve-composer branch September 20, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jordisala1991 @phansys @VincentLanglet