Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.0 #474

Merged
merged 2 commits into from
Feb 3, 2022
Merged

1.7.0 #474

merged 2 commits into from
Feb 3, 2022

Conversation

VincentLanglet
Copy link
Member

No description provided.

@VincentLanglet VincentLanglet mentioned this pull request Jan 29, 2022
Merged
@VincentLanglet
Copy link
Member Author

VincentLanglet commented Jan 29, 2022 •
edited

@orklah any idea why I'm getting

 MethodSignatureMustProvideReturnType - src/Collection/AuditedCollection.php:127:21 - Method SimpleThings\EntityAudit\Collection\AuditedCollection::add must have a return type signature! (see https://psalm.dev/282)
    public function add($element)

errors ?

Is there a regression in psalm 4.19.0 ?

Edit: sticking the version to 4.18 solve the issue, so yes it's a regression.

Edit: seems like the doctrine plugin stubs are considered as native files.

@VincentLanglet VincentLanglet mentioned this pull request Jan 29, 2022
Closed
@VincentLanglet VincentLanglet reopened this Feb 3, 2022
@VincentLanglet VincentLanglet requested review from jordisala1991 and a team February 3, 2022 21:24
@VincentLanglet VincentLanglet merged commit 7acb331 into 1.x Feb 3, 2022
@VincentLanglet VincentLanglet deleted the release/1.7.0 branch February 3, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VincentLanglet @jordisala1991