Add support for PSR clock #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X-Coder264
force-pushed
the
add-clock-support
branch
from
7b2a22b
to
4a6bae8
Compare
VincentLanglet
requested changes
Feb 8, 2023
| 'username' => $this->config->getCurrentUsername(), | ||
| ], | ||
| [ | ||
| Types::DATETIME_MUTABLE, | ||
| Types::DATETIME_IMMUTABLE, |
There was a problem hiding this comment.
Isn't this change a BC-break ? I dunno what it imply.
There was a problem hiding this comment.
It's not a BC break. The query either executes or it doesn't (it obviously executes fine as all the tests are passing).
All the types do is tell DBAL which \Doctrine\DBAL\Types\Type child class to use to get the value to bind to the query, more specifically in this case whether to call \Doctrine\DBAL\Types\DateTimeType::convertToDatabaseValue or \Doctrine\DBAL\Types\DateImmutableType::convertToDatabaseValue.
X-Coder264
force-pushed
the
add-clock-support
branch
from
4a6bae8
to
04bd279
Compare
VincentLanglet
approved these changes
Feb 8, 2023
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because it adds a new feature without a BC-break.
Changelog