Allow multiple relationships to a target entity. #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lationships to the same associated entity.
|
Hi, thanks for the PR ; are you able to add a test to avoid a regression ? |
…same target entity. Tests and closes sonata-project#614
|
@VincentLanglet Added tests. |
|
Hi, I fixed the issue coming from the 1.x branch in #616. Please rebase Thanks. |
|
@VincentLanglet I merged the main branch into the PR branch. |
You also need to fix the failing build on your branch |
VincentLanglet
approved these changes
Apr 17, 2024
|
Gonna fix it |
|
@VincentLanglet Thank you! Sorry, week started off hectic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
A cache key including the join table name fixes the issue where multiple many-to-many relationships to the same associated entity throws a Duplicate Key exception. This occurs because cache key was only storing the entity class name and target entity class name.
Closes #614.
Changelog
### Fixed Allow multiple relationships to the same target entity.