first round of review

src/Admin/AbstractAdmin.php

@@ -1749,6 +1749,8 @@ public function isCurrentChild(): bool
 
     /**
      * Returns the current child admin instance.
+     *
+     * @return AdminInterface|null the current child admin instance
      */
     public function getCurrentChildAdmin(): ?AdminInterface
     {

src/Admin/AdminInterface.php

@@ -135,6 +135,9 @@ public function getSecurityInformation(): array;
 
     public function setParentFieldDescription(FieldDescriptionInterface $parentFieldDescription): void;
 
+    /**
+     * @throws \LogicException
+     */
     public function getParentFieldDescription(): FieldDescriptionInterface;
 
     /**

src/Mapper/BaseMapper.php

@@ -51,7 +51,10 @@ abstract public function get(string $key);
 
     abstract public function has(string $key): bool;
 
-    abstract public function remove(string $key): self;
+    /**
+     * @return static
+     */
+    abstract public function remove(string $key);
 
     /**
      * Returns configured keys.
@@ -62,6 +65,8 @@ abstract public function keys(): array;
 
     /**
      * @param string[] $keys field names
+     *
+     * @return static
      */
-    abstract public function reorder(array $keys): self;
+    abstract public function reorder(array $keys);
 }

src/Show/ShowMapper.php

@@ -107,7 +107,7 @@ public function has(string $key): bool
         return $this->list->has($key);
     }
 
-    public function remove(string $key): BaseMapper
+    public function remove(string $key): self
     {
         $this->admin->removeShowFieldDescription($key);
         $this->list->remove($key);
@@ -160,7 +160,7 @@ final public function keys(): array
         return array_keys($this->list->getElements());
     }
 
-    public function reorder(array $keys): BaseMapper
+    public function reorder(array $keys): self
     {
         $this->admin->reorderShowGroup($this->getCurrentGroupName(), $keys);