Fix getSortBy and getSortOrder return typehint

sonata-project · Aug 16, 2020 · 1a3b072 · 1a3b072
1 parent f256676
commit 1a3b072
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Datagrid/ProxyQueryInterface.php b/src/Datagrid/ProxyQueryInterface.php
@@ -40,11 +40,11 @@ public function execute(array $params = [], ?int $hydrationMode = null);
      */
     public function setSortBy(array $parentAssociationMappings, array $fieldMapping): self;
 
-    public function getSortBy(): string;
+    public function getSortBy(): ?string;
 
     public function setSortOrder(string $sortOrder): self;
 
-    public function getSortOrder(): string;
+    public function getSortOrder(): ?string;
 
     /**
      * @return mixed
@@ -62,6 +62,8 @@ public function getMaxResults(): ?int;
     public function getUniqueParameterId(): int;
 
     /**
+     * Join entities from the given association mappings and return the last alias created.
+     *
      * @param mixed[] $associationMappings
      */
     public function entityJoin(array $associationMappings): string;

diff --git a/tests/App/Datagrid/ProxyQuery.php b/tests/App/Datagrid/ProxyQuery.php
@@ -31,7 +31,7 @@ public function setSortBy(array $parentAssociationMappings, array $fieldMapping)
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getSortBy(): string
+    public function getSortBy(): ?string
     {
         return 'e.id';
     }
@@ -41,7 +41,7 @@ public function setSortOrder(string $sortOrder): ProxyQueryInterface
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getSortOrder(): string
+    public function getSortOrder(): ?string
     {
         return 'ASC';
     }