Fix fatal error in strict mode

Fixed strlen() issue when it receives null value in strict mode.
sonata-project · Mar 2, 2018 · 7bfe01d · 7bfe01d
1 parent 482ec8b
commit 7bfe01d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php b/src/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php
@@ -395,8 +395,9 @@ private function replaceDefaultArguments(
 
         foreach ($defaultArguments as $index => $value) {
             $declaredInParent = $parentDefinition && array_key_exists($index, $parentArguments);
+            $argumentValue = $declaredInParent ? $parentArguments[$index] : $arguments[$index];
 
-            if (0 == strlen($declaredInParent ? $parentArguments[$index] : $arguments[$index])) {
+            if (null === $argumentValue || 0 === strlen($argumentValue)) {
                 $arguments[$declaredInParent ? sprintf('index_%s', $index) : $index] = $value;
             }
         }