Fix for #2504 #3661
Fix for #2504 #3661
Conversation
| @@ -1,35 +1,37 @@ | |||
| {% macro render_groups(admin, form, groups, has_tab) %} | |||
| <div class="row"> | |||
|
|
|||
| {% for code in groups %} | |||
| {% set form_group = admin.formgroups[code] %} | |||
| {% for code in groups %} | |||
There was a problem hiding this comment.
I think in twig you can do this directly : {% for code in groups if admin.formgroups[code] is defined %}
There was a problem hiding this comment.
Indeed you can, thanks for the tip - I have added this and pushed it now
|
This would work, but it's not a good solution. Would be better if the |
|
@core23 would you have any idea where I can check for and remove this key? I was hoping for a more eloquent solution, but I just need someone to point me in the right direction. |
|
No idea, I was working on the same problem. Meanwhile... Can you reproduce this issue on the latest dev-master version? |
|
This is an alternative solution #2814 |
|
I haven't tried since I created the PR, I will take a look when it is Monday and I am sober :) |
|
@core23 Yeah, I just grabbed the latest version and the error is still present. |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
I encountered issue #2504 when trying to remove elements from the FOS User form. The removal was copy pasted from a working 2.3 install, so I was reasonably sure my code was not at fault. I dug around a little and found that by adding a safety check in the form macro then the issue is resolved.
I don't know much about the root cause, I am guessing it is to do with inherited properties but it is just that - a guess. Maybe someone who knows more about the project can come up with a more eloquent solution?