Update AbstractAdmin::hasSubject() in order to call AbstractAdmin::getSubject() to trigger the subject detection
#4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:getSubject()` to trigger the subject detection
soullivaneuh
reviewed
Jul 5, 2017
| @@ -1701,7 +1701,7 @@ public function getSubject() | |||
| */ | |||
| public function hasSubject() | |||
| { | |||
| return $this->subject != null; | |||
| return $this->getSubject() != null; | |||
There was a problem hiding this comment.
In this case, != null is not necessary. Am I right?
There was a problem hiding this comment.
Casting to boolean instead might be better, but this was not introduced by @phansys
|
@phansys will you fix the tests? I will gladly do this, but I will need you to accept my PR on your branch. |
|
Could you please rebase your PR and fix merge conflicts? |
|
@vyshkant I think you can create a new PR an reference this one |
|
@OskarStark See #4738 |
|
Closing in favor of #4738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because
AbstractAdmin::hasSubject()returnsfalsesinceAbstractAdmin::$subjectis not hydrated untilAbstractAdmin::getSubject()is called.Closes #4569
Changelog
To do