Allow null
values as argument 1 for FieldDescriptionInterface::getFieldValue()
#4998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is BC fix.
Changelog
Subject
As context, I must mention the scenario in which the received subject is
null
.I have a simple set of geo entities (City, State, Country) which have many-to-one association respectively (a country may have n states, a state may have n cities). I use these entities within others, like User. The association between User and City is many-to-one and is NULLABLE. So, in my
UserAdmin::configureShowFields()
I have the following call:then, when there is no city for a user, value passed to
BaseFieldDescription::getFieldValue()
is null.From #4947, with the described situation, this method throws the mentioned exception, since
get_class()
receivesnull
as argument.If you want to contribute with another approach for this fix, please let me know.