checking csrf_protection in delete method. #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Oct 12, 2019
greg0ire
reviewed
Oct 12, 2019
greg0ire
reviewed
Oct 12, 2019
greg0ire
reviewed
Oct 12, 2019
|
There is a tiny CS issue to fix |
phansys
requested changes
Oct 14, 2019
|
Could you please rebase your PR and fix merge conflicts? |
|
Can you please rebase @oleg-andreyev ? |
oleg-andreyev
force-pushed
the
check-csrf_protection-in-delete-action
branch
from
458f5aa
to
a887c5b
Compare
|
@core23 done. |
OskarStark
approved these changes
Nov 11, 2019
phansys
approved these changes
Nov 11, 2019
|
Hi ! This PR seems to introduce a bug, cf #5915 Isn't another way to get the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
There are cases when I can disable
csrf_protectionvia$formOptions, but when I call deleted method this option is ignored, becausedeleteActiondoes not useFormIdeally when
deleteActionshould use "delete" form (empty form)I am targeting this branch, because feature.
Changelog
To do