Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: Illegal offset type in isset or empty #5772

Merged
merged 4 commits into from Feb 2, 2020

Conversation

peter-gribanov
Copy link
Contributor

@peter-gribanov peter-gribanov commented Dec 3, 2019

Subject

Fix error in src/Resources/views/CRUD/list_choice.html.twig at line 43 if use list of ValueObject as values for entity.

Warning: Illegal offset type in isset or empty

This condition is failed if val is object:

{% if field_description.options.choices[val] is defined %}

Related #5767

Changelog

### Fixed
- Fix error of using list ValueObject as editable field in list fields.

@phansys phansys added the patch label Dec 3, 2019
@stale
Copy link

stale bot commented Feb 1, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Feb 1, 2020
core23
core23 previously approved these changes Feb 1, 2020
@stale stale bot removed the wontfix label Feb 1, 2020
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
peter-gribanov and others added 2 commits February 2, 2020 15:30
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
@greg0ire
Copy link
Contributor

greg0ire commented Feb 2, 2020

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

  1. git rebase -i origin/3.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
  2. A window will show up with many lines, replace pick with fixup on every line but the first one
  3. Close your editor, git should do its magic, and you should end up with one commit
  4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

@peter-gribanov
Copy link
Contributor Author

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

I can't do this through the github interface, but you can do this when merging. Or i can do it when i have a time.

@greg0ire greg0ire merged commit 57c972a into sonata-project:3.x Feb 2, 2020
@peter-gribanov peter-gribanov deleted the multiple_choice branch February 2, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants