Drop SonataIntlBundle

[franmomu]

Subject

I was in the middle of dropping support of Symfony < 4.4 and adding support of 5 in master branch. The problem is that SonataIntlBundle doesn't support Symfony 5 and looks like it's not easy because of SonataUserBundle.

So I decided to remove SonataIntlBundle dependency. Right now if the bundle is enabled, it will automatically load its templates to use localized information. I basically copied the templates and then modified them to use twig/intl-extra functions.

This is not finished, I have to try it, but before going further, I would like to see if that's fine.

I am targeting this branch, because this changes are BC.

Changelog

### Added
- Import templates from SonataIntlBundle
### Removed
- Dropped SonataIntlBundle

To do

• Update the tests
• Update the documentation

[greg0ire]

Please add a call to info()

[core23]

Do we need an own instance of this class? I prefer updating the docs and refer to the intl docs instead of registering a new instance.

[franmomu]

mmm what I can do is to only load this when the SonataIntlBundle is used to maintain BC and remove this in the next major version. And also update the docs to show how to use it.

[core23]

AFAIK, you should set the default of use_intl_templates to true to keep BC. So we don't need a BC layer here.

[franmomu]

I think the intl templates are only loaded when SonataIntlBundle is enabled.

I'll be away some days, I'll continue when I come back or if someone wants to continue, feel free to do it.

[franmomu]

Here I am again! so I think these are the the scenarios here:

• The user doesn't have SonataIntlBundle installed:
  • Right now the bundle doesn't load anything.
  • use_intl_templates: true it will load the intl templates and register the service.
  • use_intl_templates: false it won't load anything.
• The user has SonataIntlBundle installed:
  • Right now the bundle loads the intl templates and the SonataIntlBundle load the Twig extension that registers the twig functions needed.
  • use_intl_templates: true it will load the intl templates and register the service.
  • use_intl_templates: false it will also load the intl templates and register the service.

[core23]

So there is no change if you are still using SonataIntlBundle?

[franmomu]

It will load the intl templates but from the AdminBundle. We could throw a warning deprecation in case you have installed SonataIntlBundle but not enabled use_intl_templates.

I removed the definition and added the twig/extra-bundle so there is no need to register the service.

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[VincentLanglet]

is something missing in this PR to be merged ? @greg0ire @core23 @franmomu :)

[greg0ire]

Thanks @franmomu !