[WIP] Allow Twig 3

[phansys]

Subject

Allow Twig 3.

I am targeting this branch, because these changes can not be done at the stable branch.

Related to #5788, symfony/symfony#35649.

Changelog

### Added
- Added support for "twig/twig:^3.0".

To do

• Use stable versions of "sonata-project/form-extensions" and "sonata-project/twig-extensions" when released;
• Ensure results from StringExtension is the same as TextExtension;
• Wait for the removal of "sonata-project/intl-bundle".

When symfony/symfony#35649 is available in a stable release, we need to remove some of the stuff added in this PR and bump "symfony/string" to the version which ships them.
Regarding the Twig truncate filter, I had to make some slight modifications at test assertions since the new behavior differs a little bit from the previous one. Plus, I renamed "preserve" option to "cut", in order to be consistent with the term used at the String component (which also has the opposite behavior than "preserve").
In this way, I think we should deprecate the "preserve" option at the stable branch.

[phansys]

We could try to move StringExension (and UnicodeString) added here to the stable branch, and then, merge them later here.
The only concern I have about this is the small difference between the results from truncate() and u.truncate(), which I guess can be accepted in a major release, but the case could be not the same in a minor.
WDYT?

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[greg0ire]

I think if using the new behavior is opt-in, then it's ok to have it in the stable branch. It's ok to deprecate the old behavior in favor of a new one if you don't force it on people. They will be more happy to see it clearly in a minor than have it non-obvious, in the middle of other things in a big major.

[phansys]

Great proposal. I'll be working on that path.
Thank you.

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[greg0ire]

What's the status of this? Should it be reviewed or is it too soon? I see there is an unchecked checkbox in the todo list

[phansys]

What's the status of this? Should it be reviewed or is it too soon? I see there is an unchecked checkbox in the todo list

We need to decide what to do with "sonata-project/intl-bundle", since it provides some helper functions over the basic Intl features (#5975 (comment)).

/cc @franmomu.

[franmomu]

What's the status of this? Should it be reviewed or is it too soon? I see there is an unchecked checkbox in the todo list

We need to decide what to do with "sonata-project/intl-bundle", since it provides some helper functions over the basic Intl features (#5975 (comment)).

/cc @franmomu.

I was thinking... what about to not deprecate the bundle?

It could be updated using twig/intl-extra package (and make it compatible with Twig 3 and Symfony 5) and remove the UserBasedTimezoneDetector to remove the dependency with user-bundle? We could add a recipe showing how to add it.

To me, it looks more like it should belong to a separated package instead of the AdminBundle one.

[phansys]

I agree @franmomu.
Even, maybe we could leave this class and do something like this:

public function getTimezone()
{
    if (!($token = $this->securityContext->getToken()) || !is_object($user = $token->getUser())) {
        return null;
    }

    if ($user instanceof 'Sonata\UserBundle\Model\User') {
        return $user->getTimezone();
    }

    $ro = new \ReflectionObject($user);
    if ($ro->hasMethod('getTimezone')) {
        $rm = $ro->getMethod('getTimezone');

        if ($rm->isPublic() && !$rm->isStatic() && 0 === $rm->getNumberOfRequiredParameters()) {
            return $user->getTimezone();
        }
    }

    return null;
}

But I'd prefer to declare a TimezoneAwareInterface in "sonata-project/intl-bundle", implement it at "sonata-project/user-bundle", and check against that interface instead.

WDYT?

[franmomu]

But I'd prefer to declare a TimezoneAwareInterface in "sonata-project/intl-bundle", implement it at "sonata-project/user-bundle", and check against that interface instead.

WDYT?

Exactly, I think this is the best way to deal with sonata/intl-bundle right now.

[VincentLanglet]

What's the next step @franmomu @phansys ?

[phansys]

We need to make the required changes at "sonata-project/intl-bundle". I had no time these weeks.
If someone can, help is welcomed.

[VincentLanglet]

Seems like a discussion about the status of the SonataIntlBundle is needed then, I thought it was deprecated sonata-project/SonataIntlBundle#280...

@sonata-project/contributors ?

If it's not deprecated anymore, we should start by updating the bundle description.

[SonataCI]

Could you please rebase your PR and fix merge conflicts?

[VincentLanglet]

I think you can close this PR @phansys, isn't it ?

[phansys]

I think you can close this PR @phansys, isn't it ?

Yes, I guess. Closing.