fix: add datetime in editable date form types for SetObjectFieldValue… #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Action When using editable datetime formtype in datagrid configuration the case was not handled correctly since Action introduction. Until now only editable date fields were correctly handled. This PR fix this behaviour and add the datetime formtype as transformable to DateTime Tests have been added to illustrate the case, without the PR testSetObjectFieldValueActionWithDateTime wouldn't pass.
greg0ire
approved these changes
May 2, 2020
|
Thanks @VincentLanglet @xleliberty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to #6034
I just rebase 3.x and squash commit. The fork doesn't allow pushes from maintainers.
Fix datetime not handled correctly in editable formtypes of SetObjectFieldValueAction
We have found a bug introduced in 3.38 with SetObjectFieldValueAction.
When using editable datetime formtype in datagrid configuration
the case was not handled correctly anymore since Action introduction (3.38.0)
Until now only editable "date" fields were correctly handled.
This PR fix this behaviour and add the datetime formtype as
transformable to DateTime to be correctly handled in typehinted setters
Tests have been added to illustrate the case
Without the PR
testSetObjectFieldValueActionWithDateTime wouldn't pass.
I am targeting this branch, because this patch is backward compatible up to 3.38
Changelog
Closes #6034