allow symfony/http-foundation and symfony/validator 5.1 #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
commented
Aug 28, 2020
Codecov Report
@@ Coverage Diff @@
## 3.x #6344 +/- ##
=========================================
Coverage 77.50% 77.50%
- Complexity 2603 2605 +2
=========================================
Files 142 142
Lines 7779 7785 +6
=========================================
+ Hits 6029 6034 +5
- Misses 1750 1751 +1
Continue to review full report at Codecov.
|
dmaicher
force-pushed
the
more_symfony_5_compat
branch
from
a77df2e
to
d42ae49
Compare
dmaicher
commented
Aug 28, 2020
dmaicher
force-pushed
the
more_symfony_5_compat
branch
2 times, most recently
from
3760963
to
05588e6
Compare
dmaicher
commented
Aug 28, 2020
phansys
previously approved these changes
Aug 29, 2020
franmomu
previously approved these changes
Aug 30, 2020
|
You will need to rebase again |
dmaicher
force-pushed
the
more_symfony_5_compat
branch
from
05588e6
to
2f9acac
Compare
jordisala1991
approved these changes
Aug 30, 2020
franmomu
approved these changes
Aug 31, 2020
wbloszyk
approved these changes
Aug 31, 2020
|
Thank you @dmaicher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I propose to allow symfony/http-foundation and symfony/validator 5.1.
I am targeting this branch, because its BC and would be nice to have 3.x fully support symfony 5.1 soon.
Changelog