Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent addFormFieldDescription if field role no granted #6364

Merged
merged 2 commits into from
Sep 6, 2020
Merged

Prevent addFormFieldDescription if field role no granted #6364

merged 2 commits into from
Sep 6, 2020

Conversation

kirya-dev
Copy link
Contributor

@kirya-dev kirya-dev commented Sep 2, 2020

Subject

I am targeting this branch, because im think that no needed handle field if role no granted.

Closes #6338.

Changelog

### Changed
-  Prevent `addFormFieldDescription` if field role no granted

To do

  • Update the tests;

@kirya-dev
Copy link
Contributor Author

What are you think now?

@VincentLanglet VincentLanglet requested a review from a team September 6, 2020 08:33
@VincentLanglet VincentLanglet merged commit 86a8777 into sonata-project:3.x Sep 6, 2020
@VincentLanglet
Copy link
Member

Thanks @kirya-dev

@kirya-dev kirya-dev deleted the closes-issue-6338 branch September 10, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug in FormMapper:add()
5 participants