Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ModelManagerInterface::supportsQuery #6381

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Add ModelManagerInterface::supportsQuery #6381

merged 1 commit into from
Sep 16, 2020

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Sep 8, 2020 •
edited

Subject

I am targeting this branch, because BC.

Closes #6273.

Changelog

### Added
- Added `ModelManagerInterface::supportsQuery()`

### Deprecated
- Create a new instance of ModelChoiceLoader with a query unsupported by the modelManager

@VincentLanglet VincentLanglet requested a review from a team September 8, 2020 22:13
phansys
phansys requested changes Sep 9, 2020
View reviewed changes
src/Form/ChoiceList/ModelChoiceLoader.php Outdated Show resolved Hide resolved
tests/Form/ChoiceList/ModelChoiceLoaderTest.php Outdated Show resolved Hide resolved
@phansys phansys added the minor label Sep 9, 2020
core23
core23 requested changes Sep 9, 2020
View reviewed changes
src/Model/ModelManagerInterface.php Outdated Show resolved Hide resolved
phansys
phansys requested changes Sep 9, 2020
View reviewed changes
src/Model/ModelManagerInterface.php Outdated Show resolved Hide resolved
src/Model/ModelManagerInterface.php Outdated Show resolved Hide resolved
src/Form/ChoiceList/ModelChoiceLoader.php Outdated Show resolved Hide resolved
src/Form/ChoiceList/ModelChoiceLoader.php Outdated Show resolved Hide resolved
tests/App/Model/ModelManager.php Outdated Show resolved Hide resolved
tests/Form/ChoiceList/ModelChoiceLoaderTest.php Outdated Show resolved Hide resolved
phansys
phansys previously approved these changes Sep 9, 2020
View reviewed changes
core23
core23 previously requested changes Sep 9, 2020
View reviewed changes
tests/Form/ChoiceList/ModelChoiceLoaderTest.php Outdated Show resolved Hide resolved
@VincentLanglet VincentLanglet force-pushed the supportQuery branch 3 times, most recently from 5a94411 to ee448ef Compare September 13, 2020 20:42
@VincentLanglet VincentLanglet requested review from core23 and a team September 13, 2020 20:44
@VincentLanglet VincentLanglet changed the title Add ModelManagerInterface::supportQuery Add ModelManagerInterface::supportsQuery Sep 13, 2020
@VincentLanglet VincentLanglet requested review from core23 and removed request for core23 September 15, 2020 21:11
@VincentLanglet
Copy link
Member Author

Can you take a look @core23 ?

Or can it be dismissed ? (@greg0ire ?)

@greg0ire greg0ire dismissed core23’s stale review September 16, 2020 08:52

Review has been addressed

@greg0ire greg0ire merged commit 43f6e93 into sonata-project:3.x Sep 16, 2020
@greg0ire
Copy link
Contributor

Thanks @VincentLanglet !

@franmomu franmomu mentioned this pull request Sep 16, 2020
Merged
@VincentLanglet VincentLanglet deleted the supportQuery branch March 27, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@phansys phansys phansys approved these changes

@core23 core23 Awaiting requested review from core23

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a ModelManagerInterface::supports (or another name)
5 participants
@VincentLanglet @greg0ire @jordisala1991 @phansys @core23