Deprecate ORM related functions on ProxyQueryInterface #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
deprecate_proxy
branch
from
4e94e40
to
9fdeded
Compare
core23
previously approved these changes
Sep 13, 2020
OskarStark
reviewed
Sep 13, 2020
src/Datagrid/ProxyQueryInterface.php
Outdated
| @@ -94,11 +94,19 @@ public function setMaxResults($maxResults); | |||
| public function getMaxResults(); | |||
|
|
|||
| /** | |||
| * NEXT_MAJOR: Remove this method. | |||
There was a problem hiding this comment.
this method from the interface.
?
Otherwise it could be a bit misleading IMO
There was a problem hiding this comment.
I've changed it. I think if we usually put NEXT_MAJOR comments next to the every file affected, so I usually understand that if there is no more instructions than Remove this method, it's to remove the method where the NEXT_MAJOR comment is.
BTW I had forgotten to add the comment to the implementation in tests 😬
franmomu
force-pushed
the
deprecate_proxy
branch
from
9fdeded
to
93f94a5
Compare
phansys
reviewed
Sep 14, 2020
These functions are only implemented in SonataDoctrineORMAdminBundle
franmomu
force-pushed
the
deprecate_proxy
branch
from
93f94a5
to
c86f2b1
Compare
VincentLanglet
approved these changes
Sep 14, 2020
jordisala1991
approved these changes
Sep 14, 2020
phansys
approved these changes
Sep 14, 2020
|
Thank you @franmomu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Apparently
getUniqueParameterIdandentityJoinare only used in the ORM Bundle, in the other persistence bundles (also not maintained ones) the implementation is empty because they are not useful.I am targeting this branch, because these changes are BC.
Changelog