Add TemplateRegistryAwareInterface #6390
Conversation
| * @return MutableTemplateRegistryInterface | ||
| */ | ||
| final public function getTemplateRegistry() | ||
| final public function getTemplateRegistry(): ?MutableTemplateRegistryInterface |
There was a problem hiding this comment.
I can in 3.x.
It won't in master. A next major would be needed indeed.
| interface TemplateRegistryOwnerInterface | ||
| { | ||
| // NEXT_MAJOR: uncomment this method in 4.0 | ||
| //public function getTemplateRegistry(): MutableTemplateRegistryInterface; |
| @@ -1353,7 +1353,7 @@ public function generateMenuUrl($name, array $parameters = [], $referenceType = | |||
| return $this->routeGenerator->generateMenuUrl($this, $name, $parameters, $referenceType); | |||
| } | |||
|
|
|||
| final public function setTemplateRegistry(MutableTemplateRegistryInterface $templateRegistry) | |||
| final public function setTemplateRegistry(MutableTemplateRegistryInterface $templateRegistry): void | |||
|
Other packages use the term "aware" instead "owner" for cases like this ( |
wbloszyk
force-pushed
the
add_template_reg_interface
branch
from
1b49dbf
to
4b0d16b
Compare
wbloszyk
changed the title
|
@wbloszyk Please wait for multiple approval before merging (generally 2 is fine). |
|
I ask about merge on slack. I prefer 1 approve per refactoring PR and 2+ for new feature. |
| namespace Sonata\AdminBundle\Templating; | ||
|
|
||
| /** | ||
| * /** |
It's a team project. And people can't be connected every day. |
|
Also, it's open-source software… there are a loooooot more users than a company project. |
Subject
I am targeting this branch, because this change respect BC.
Changelog