#6629 Replace jQuery "load" with "on" #6630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace jQuery(window).load with jQuery(window).on('load', handler)
sonata-project#6629
VincentLanglet
approved these changes
Nov 26, 2020
|
I would say it's pedantic and don't need a Changelog @sonata-project/contributors ? |
|
When could we expect a review of this PR to finish off the issue? Thanks. |
phansys
approved these changes
Dec 1, 2020
|
Thanks @timwentzell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace jQuery(window).load with jQuery(window).on('load', handler)
#6629
Subject
This is a simple PR to replace the deprecated (since jQuery 1.8) and removed (since jQuery 3.0) usage of jQuery.load(handler) with jQuery.on('load', handler).
I am targeting this branch, because I would like our Sonata projects to have better compatibility with newer versions of jQuery.
Closes #6629.
Changelog