Fix argument 3 of AdminMaker #6772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes when the third argument of AdminMaker is a service name instead of a class. It retrieves the service name and replaces it with the class name.
There was a problem hiding this comment.
There is some NEXT_MAJOR comment to add because in master the controller will be the second argument and not the third (Since it will be required I had to make this change in #6770)
Merged
VincentLanglet
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
The third argument of
AdminMakercould be a service name:SonataAdminBundle/src/Resources/config/makers.php
Line 27 in d3f9b58
This PR adds a compiler pass which retrieves this parameters and check if it is a service, in that case, it replaces the argument 3 by the class name of the service definition.
I am targeting this branch, because this is BC.
Changelog