Use camel case for arguments and variables at CRUDController::historyCompareRevisionsAction()
#6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are passing, but I think the exit code is not 0 given the limit configured for the deprecation messages: |
|
I think #6911 could fix your issue |
phansys
changed the title
CRUDController::historyCompareRevisionsAction()CRUDController::historyCompareRevisionsAction()
phansys
force-pushed
the
camel_case
branch
2 times, most recently
from
454a551
to
9eeda0a
Compare
VincentLanglet
previously approved these changes
Mar 6, 2021
core23
requested changes
Mar 6, 2021
| @@ -47,7 +47,7 @@ public function build(AdminInterface $admin, RouteCollection $collection) | |||
| if ($this->manager->hasReader($admin->getClass())) { | |||
| $collection->add('history', sprintf('%s/history', $admin->getRouterIdParameter())); | |||
| $collection->add('history_view_revision', sprintf('%s/history/{revision}/view', $admin->getRouterIdParameter())); | |||
| $collection->add('history_compare_revisions', sprintf('%s/history/{base_revision}/{compare_revision}/compare', $admin->getRouterIdParameter())); | |||
| $collection->add('history_compare_revisions', sprintf('%s/history/{baseRevision}/{compareRevision}/compare', $admin->getRouterIdParameter())); | |||
There was a problem hiding this comment.
Not sure if you should change the route in a stable release
There was a problem hiding this comment.
I'll try to check how could we deal with this.
There was a problem hiding this comment.
@core23, I added a BC layer for those cases where the param names are explicitly used.
phansys
force-pushed
the
camel_case
branch
2 times, most recently
from
752b437
to
301eefc
Compare
VincentLanglet
previously approved these changes
Mar 9, 2021
core23
reviewed
Mar 10, 2021
| @@ -866,38 +866,62 @@ public function historyCompareRevisionsAction($id = null, $base_revision = null, | |||
|
|
|||
| $reader = $manager->getReader($this->admin->getClass()); | |||
|
|
|||
| // NEXT_MAJOR: Remove this condition. | |||
There was a problem hiding this comment.
Can you provide a test that verifies this hack?
…yCompareRevisionsAction()`
core23
approved these changes
Mar 10, 2021
wbloszyk
approved these changes
Mar 10, 2021
VincentLanglet
approved these changes
Mar 10, 2021
|
Thanks @phansys |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Use camel case for arguments and variables at
CRUDController::historyCompareRevisionsAction().I am targeting this branch, because these changes respect BC.
Changelog