Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the navigation role from nav #6968

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Remove the navigation role from nav #6968

merged 1 commit into from
Mar 26, 2021

Conversation

axzx
Copy link
Contributor

@axzx axzx commented Mar 24, 2021

Subject

The navigation role is unnecessary for element nav.

I am targeting this branch, because BC.

Changelog

### Removed
Remove the navigation role from nav.

VincentLanglet
VincentLanglet approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Navigation_Role

@VincentLanglet VincentLanglet requested a review from a team March 24, 2021 22:16
@VincentLanglet VincentLanglet merged commit 06877d7 into sonata-project:3.x Mar 26, 2021
@axzx axzx deleted the patch-1 branch March 26, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franmomu franmomu franmomu approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@axzx @franmomu @VincentLanglet