Add tests to filter types and fix options #7007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I wanted to work a bit with filters, but before starting, better to have some tests.
Adding them showed that:
format
is not valid forDateTimeRangeType
because this Type adds twoDateTimeType
that have that configuration (notDateTimeRangeType
itself), so I've added theformat
option in thefield_options
option so is passed to thoseDateTimeType
and changed fromDateType::HTML5_FORMAT
toDateTimeType::HTML5_FORMAT
.date_format
is not valid forDateType
, so I've changed it toformat
.Another interesting part I was thinking was... why has it worked so far? Because having:
The
field_options
option is an array and we always override this array (here for example), and by doing this, it does not merge the values, so thisdate_format
always gets lost.If we want to allow nested options we should use a closure instead (useful also for #6078), but that's another issue (that I think we should consider).
I am targeting this branch, because these changes are BC.
Changelog