Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template for datagrid #7037

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Apr 12, 2021

Subject

I am targeting this branch, because it's a minor.

Fixed an error on SonataDoctrineORMAdminBundle:

ERROR: InvalidArgument - src/Builder/DatagridBuilder.php:150:71 - Argument 3 of Sonata\AdminBundle\Datagrid\Datagrid::__construct expects Sonata\AdminBundle\Datagrid\PagerInterface<Sonata\AdminBundle\Datagrid\ProxyQueryInterface>, Sonata\AdminBundle\Datagrid\PagerInterface<Sonata\DoctrineORMAdminBundle\Datagrid\ProxyQueryInterface> provided (see https://psalm.dev/004)
        return new Datagrid($admin->createQuery(), $admin->getList(), $pager, $formBuilder, $values);

Changelog

### Added
- Generics for Datagrid and DatagridInterface

@VincentLanglet VincentLanglet requested a review from a team April 12, 2021 07:00
@VincentLanglet VincentLanglet requested a review from a team April 13, 2021 19:04
@VincentLanglet VincentLanglet merged commit 9524621 into sonata-project:3.x Apr 14, 2021
@VincentLanglet VincentLanglet deleted the datagrid branch April 14, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants