Leverage FieldDescriptionInterface::getOption() in views

[phansys]

Subject

Leverage FieldDescriptionInterface::getOption() in views.

I am targeting this branch, because these changes respect BC.

Many usages of the Twig's default filter were removed, leveraging the argument 2 of FieldDescriptionInterface::getOption().

Changelog

### Changed
- Calls to `FieldDescriptionInterface::getOptions()` by calls to `FieldDescriptionInterface::getOption()` in views.

[jordisala1991]

I think that could fix: #7029

[franmomu]

As a general rule, should we change from:

variable.field_description.options.some_option is defined and variable.field_description.options.some_option 

to

variable.field_description.option('some_option') is not null

to be explicit?

[phansys]

I don't think so, because variable.field_description.option('some_option') is not null evaluates to true when the "some_option" option is set with the value false, and in this example, the condition is trying to check if the option is holding a truthy value.

[franmomu]

Maybe we should add a hasOption method, that would make things clearer IMO (but that's another issue).

[VincentLanglet]

@phansys This is a BC-break

Before, using

{%- include '@SonataAdmin/CRUD/display_boolean.html.twig' -%}

in a non-fielddescriptions context could work, since there was a is defined check every where.
Now it throw an error.

Also, before passgin fieldDescription: { options: { ... }} could work. Now it doesn't.

I think it could be great having the display_ template to work without the need of fieldDescriptions.
Usage could be

include '@SonataAdmin/CRUD/display_boolean.html.twig' with (inverse: fieldDescriptions.getOption('inverse', false))

And the code

{% if field_description.option('inverse', false) ? not value : value %}

would be changed to

{% if inverse|default(false) ? not value : value %}

The current bugfix could be

{% if field_description.option('inverse', false)|default(false) ? not value : value %}

The BC-way to introduce the feature could be

{% if inverse|field_description.option('inverse', false)|default(false) ? not value : value %}

WDYT ?

[phansys]

@phansys This is a BC-break

I've experiencing the same issue with one of my custom views, but I dismissed the problem since I think we haven't a BC promise around our internal templates.
I think we could make some changes to avoid this, but I don't understand the syntax around your last snippet: inverse|field_description. Would field_description interpreted as a Twig filter?

[VincentLanglet]

I meant

Inverse|default(fielddescription.option(inverse))|default(false)

[phansys]

LGTM.