Introduce MapperInterface #7039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Mapper/BaseMapper.php
Outdated
| @@ -21,7 +21,7 @@ | |||
| * | |||
| * @author Thomas Rabaix <thomas.rabaix@sonata-project.org> | |||
| */ | |||
| abstract class BaseMapper | |||
| abstract class BaseMapper implements MapperInterface | |||
There was a problem hiding this comment.
Does it make sense at all to have this abstract... previously all method were abstract, and now it has none.
To me , an abstract class makes sense when it have some logic and some abstract method, but this class does not have any of that (previously or after this pr)
There was a problem hiding this comment.
We can deprecate it indeed.
VincentLanglet
force-pushed
the
mapperInterface
branch
3 times, most recently
from
0ad302c
to
262aefe
Compare
phansys
previously approved these changes
Apr 14, 2021
VincentLanglet
force-pushed
the
mapperInterface
branch
from
262aefe
to
23fd9fa
Compare
phansys
approved these changes
Apr 14, 2021
jordisala1991
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
We're using
BaseMapperas a typehint somewhere, which is an abstract class.Isn't better to use an interface instead ?
Changelog