Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use field description constants #7063

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Use field description constants #7063

merged 2 commits into from
Apr 14, 2021

Conversation

franmomu
Copy link
Member

@franmomu franmomu commented Apr 14, 2021 •
edited

I am targeting this branch, because these changes are BC.

Changelog

### Added
- Added `XEditableExtension::FIELD_DESCRIPTION_MAPPING` to expose mapping between FieldDescription types and xEditable types

@VincentLanglet
Copy link
Member

Is it pedantic since we're exposing a new public constant ?

@franmomu
Copy link
Member Author

Is it pedantic since we're exposing a new public constant ?

At first I thought about making it @internal and then I forgot, let's change it to feature then.

@franmomu franmomu added minor and removed pedantic labels Apr 14, 2021
@jordisala1991 jordisala1991 merged commit 04b8b38 into sonata-project:3.x Apr 14, 2021
@jordisala1991
Copy link
Member

Thank you @franmomu

@franmomu franmomu deleted the use_field_description_constants branch April 14, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991 jordisala1991 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@franmomu @VincentLanglet @jordisala1991