Prepare to remove usages of service_container in version 4 #7074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
commented
Apr 16, 2021
| @@ -86,18 +103,13 @@ public function getGlobalTemplate($name): ?string | |||
| } | |||
|
|
|||
| /** | |||
| * @throws ServiceNotFoundException | |||
| * @throws ServiceCircularReferenceException | |||
| * @throws AdminCodeNotFoundException | |||
| */ | |||
| private function getTemplateRegistry(string $adminCode): TemplateRegistryInterface | |||
There was a problem hiding this comment.
This method is not being used in 3.x
franmomu
commented
Apr 16, 2021
franmomu
force-pushed
the
remove_use_container
branch
from
31efea8
to
30f8aab
Compare
VincentLanglet
approved these changes
Apr 16, 2021
jordisala1991
approved these changes
Apr 16, 2021
|
Thank you @franmomu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I missed this on in #6963
After this and merging with
4.x(resolving the comment) I think we won't have moreservice_containerdependencies.I am targeting this branch, because these changes are BC.
Changelog