Sidebar menu toggle with admin-lte 2.4 #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the complete upgrade guide: https://adminlte.io/docs/2.4/upgrade-guide @core23 can you take a look at it, just in case we missed something else? |
|
This upgrade guide is basically saying that the fact we upgraded admin-lte to 2.4 is a BC-break for the user. Simple example: If I override Should we revert the bump or at least adding the upgrade guide in our Changelog ? |
|
I added an upgrade note. Not sure about this BC break. To me it is not so important and it can be documented. wdyt? |
VincentLanglet
approved these changes
Apr 18, 2021
core23
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is a bug fix.
Changelog
The upgrade to admin lte v4: #7032 broke the sidebar menu, we are unable to toggle (open/close) it.
It is kind of bc break on their side: ColorlibHQ/AdminLTE#1666
This change fixes it.