Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed select2 ModelAutocompleteType #7196

Merged
merged 1 commit into from May 17, 2021
Merged

Fixed select2 ModelAutocompleteType #7196

merged 1 commit into from May 17, 2021

Conversation

cecicifu
Copy link
Contributor

Subject

  • Fixed error Uncaught TypeError: autocompleteInput.select2(...).append is not a function after adding a new item to ModelAutocompleteType fields.
  • Fixed error on save, id was missing from the hidden input (value attribute).

Closes #4022.

Changelog

### Fixed
- Changed .select2() to .attr()
- Set id in the value attribute of hidden input after save

@cecicifu cecicifu changed the title Wrong function & input value after save Fixed select2 ModelAutocompleteType May 16, 2021
@VincentLanglet VincentLanglet requested a review from a team May 16, 2021 19:17
@VincentLanglet VincentLanglet merged commit e8b4ea5 into sonata-project:3.x May 17, 2021
@VincentLanglet
Copy link
Member

Thanks @cecicifu

@cecicifu cecicifu deleted the patch-2 branch May 17, 2021 07:15
@willemverspyck willemverspyck mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core23 core23 core23 approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required sonata_type_model_autocomplete causing "An invalid form control with name='' is not focusable"
3 participants
@cecicifu @VincentLanglet @core23