Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sortable option as string #7206

Merged
merged 1 commit into from May 19, 2021
Merged

Conversation

franmomu
Copy link
Member

Subject

It is used as string for specify the field name for example in:

|| $values[DatagridInterface::SORT_BY]->getName() === $fieldDescription->getOption('sortable');

I am targeting this branch, because this is a patch.

Changelog

### Fixed
- Fixed type of `sortable` option in `FieldDescriptionOptions`

It is used as string for specify the field name
@franmomu franmomu added the patch label May 19, 2021
@franmomu franmomu requested a review from a team May 19, 2021 12:14
@franmomu franmomu merged commit 1d895c1 into sonata-project:3.x May 19, 2021
@franmomu franmomu deleted the sortable_type branch May 19, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants