New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not lose _route_params #7211
Conversation
How do i have the app variable in tests @sonata-project/contributors ? |
8fed8bb
to
94ad523
Compare
@@ -39,13 +39,13 @@ This code manages the one-to-many association field popup | |||
'elementId': id, | |||
'objectId': sonata_admin.admin.root.id(sonata_admin.admin.root.subject), | |||
'uniqid': sonata_admin.admin.root.uniqid, | |||
'subclass': app.request.query.get('subclass'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already inside the app.request.query.all
value.
One question, would it be enough to generate the My concern is about adding parameters that are not really needed. |
It would be enough for my case.
Yes I understand. But thinking about it, I was wondering "What is a not needed parameter ?" |
Subject
I am targeting this branch, because bugfix.
This is an attempt to fix #7185
Changelog