Stop using response_item_callback param 3 as reference #7320

VincentLanglet · 2021-07-13T13:37:20Z

Subject

I am targeting this branch, because it's a BC-break but since it can't work like this, we can consider this as a bugfix.

Closes #7298.

### Changed
- `response_item_callback` callback signature.

### Fixed
- `response_item_callback` option of ModelAutocompleteFilter.

This is not working atm

docs/reference/form_types.rst

Co-authored-by: David Maicher <mail@dmaicher.de>

franmomu · 2021-07-16T14:48:31Z

VincentLanglet added 2 commits July 13, 2021 15:34

Stop using itemCallack as reference

e3f96bb

This is not working atm

Add tests

5b08f34

VincentLanglet force-pushed the itemCallback branch from e8d9f76 to 5b08f34 Compare July 13, 2021 13:53

VincentLanglet added the patch label Jul 13, 2021

VincentLanglet requested a review from a team July 13, 2021 13:53

dmaicher previously approved these changes Jul 14, 2021

View reviewed changes

docs/reference/form_types.rst Outdated Show resolved Hide resolved

dmaicher requested a review from a team July 14, 2021 11:39

Update docs/reference/form_types.rst

9658917

Co-authored-by: David Maicher <mail@dmaicher.de>

VincentLanglet dismissed dmaicher’s stale review via 9658917 July 14, 2021 11:40

dmaicher approved these changes Jul 14, 2021

View reviewed changes

dmaicher requested a review from a team July 14, 2021 11:51

franmomu approved these changes Jul 16, 2021

View reviewed changes

franmomu merged commit 0eda880 into sonata-project:3.x Jul 16, 2021