Add support to display enums #7708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take a look at sonata-project/dev-kit#1876 for the ci |
|
@franmomu If you rebase the lint build will be fixed. |
VincentLanglet
approved these changes
Jan 17, 2022
core23
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
This PR tries to add support to display enums (backed enums) in the lists and show templates. It displays the
nameof the enum which I think is the usual behaviour, an option can be added to display thevalueinstead.Note: The first commit is about removing duplicated code, extracting the list of templates to an internal constant, I chose to move them to
TemplateRegistryInterface, but any other suggestion is welcome.I am targeting this branch, because these changes are BC.
Changelog