-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ExporterInterface usage instead of Exporter class #7994
Added ExporterInterface usage instead of Exporter class #7994
Conversation
@@ -93,7 +93,7 @@ public static function getSubscribedServices(): array | |||
'sonata.admin.audit.manager' => AuditManagerInterface::class, | |||
'sonata.admin.object.manipulator.acl.admin' => AdminObjectAclManipulator::class, | |||
'sonata.admin.request.fetcher' => AdminFetcherInterface::class, | |||
'sonata.exporter.exporter' => '?'.Exporter::class, | |||
'sonata.exporter.exporter' => '?'.ExporterInterface::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some change here:
https://github.com/sonata-project/exporter/blob/3.x/src/Bridge/Symfony/Resources/config/services.php#L64-L67
will be needed too.
See an example here:
SonataAdminBundle/src/Resources/config/core.php
Lines 152 to 157 in 6dcebd2
->set('sonata.admin.request.fetcher', AdminFetcher::class) | |
->args([ | |
new ReferenceConfigurator('sonata.admin.pool'), | |
]) | |
->alias(AdminFetcherInterface::class, 'sonata.admin.request.fetcher') |
So I think we'll need something like
$services->alias(ExporterInterface::class, 'sonata.exporter.exporter');
explorer 3.1.1 is released, you can take a new try |
c91be47
to
a7fed8f
Compare
done. I think, it should work now |
composer.json
Outdated
@@ -35,7 +35,7 @@ | |||
"psr/log": "^1.1 || ^2.0 || ^3.0", | |||
"sonata-project/block-bundle": "^4.11", | |||
"sonata-project/doctrine-extensions": "^1.8 || ^2.0", | |||
"sonata-project/exporter": "^2.11 || ^3.0", | |||
"sonata-project/exporter": "^3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sonata-project/exporter": "^3.1", | |
"sonata-project/exporter": "^2.14 || ^3.1.1", |
We need to keep the v2 support for the PHP 7.4 support.
I added the Interface on the v2 of exporter because it was simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, v2 is added
a7fed8f
to
ffcdd75
Compare
Thanks |
Subject
I am targeting this branch, because {reason}.
Closes #{put_issue_number_here}.
Changelog