Fix display of enums for nullable property #8039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedfir
approved these changes
Apr 11, 2023
VincentLanglet
approved these changes
Apr 11, 2023
jordisala1991
approved these changes
Apr 11, 2023
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
When displaying an enum in list or show view, the twig template don't check for potential null value (nullable property in entity for example) and crash with
Impossible to access an attribute ("name") on a null variable.This fix just add the missing check in
display_enum.html.twig.I am targeting this branch, because this is a patch without breaking change.
Changelog