Autocomplete attr support #8083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pietaj, can you fix the Documentation build ? |
pietaj
force-pushed
the
autocomplete-attr-support
branch
from
bfd483e
to
c532bb9
Compare
phansys
reviewed
Sep 1, 2023
phansys
reviewed
Sep 1, 2023
src/Resources/views/Form/Type/sonata_type_model_autocomplete.html.twig
Outdated
Show resolved
Hide resolved
added 4 commits
September 1, 2023 13:53
pietaj
force-pushed
the
autocomplete-attr-support
branch
from
c532bb9
to
6ce3078
Compare
|
@phansys thx for the cosmetic review, I've pushed an update to that. Anyway, I see that the tests fail on phpstan. Should I do sth about it in the scope of this PR? |
Not needed in this PR I would say, but if you want to fix it in other PR this would be awesome |
VincentLanglet
approved these changes
Sep 1, 2023
phansys
approved these changes
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because Sonata 4 does not support the attr option in ModelAutocompleteType
Sonata3 ModelAutocompleteType rendered the passed attr options into the autocomplete template allowing for custom data attributes etc. This was removed here: 8f4d466 which I think was simply overlooked
Moreover Select2 v4 no longer supports readonly, see: https://github.com/select2/select2/blob/4.0.13/CHANGELOG.md
Changelog