Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevKit updates for 4.x branch #8133

Merged
merged 8 commits into from
Dec 8, 2023
Merged

DevKit updates for 4.x branch #8133

merged 8 commits into from
Dec 8, 2023

Conversation

SonataCI
Copy link
Collaborator

@SonataCI SonataCI commented Dec 4, 2023

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Dec 4, 2023
@jordisala1991
Copy link
Member

I think the SF 7.0 compat is still missing a few changes.

/**
* @internal
*
* @phpstan-ignore-next-line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error can't be ignored like this.

@VincentLanglet
Copy link
Member

I think the SF 7.0 compat is still missing a few changes.

Build was green on #8127 (?)

@jordisala1991
Copy link
Member

jordisala1991 commented Dec 4, 2023

I think the SF 7.0 compat is still missing a few changes.

Build was green on #8127 (?)

Maybe between the RC and the stable version, something changed?

@VincentLanglet VincentLanglet force-pushed the 4.x-dev-kit branch 3 times, most recently from af8ca31 to ee88214 Compare December 8, 2023 08:33
@VincentLanglet
Copy link
Member

VincentLanglet commented Dec 8, 2023

The check 0 !== preg_match("/7\..\../", Kernel::VERSION) is not working on the Test / PHP 8.1 + highest + normal build because we're using Symfony 6.4 but phpunit-bridge 7.0

@VincentLanglet VincentLanglet merged commit 4f71371 into 4.x Dec 8, 2023
24 checks passed
@VincentLanglet VincentLanglet deleted the 4.x-dev-kit branch December 8, 2023 08:52
/** @internal */
interface CompatibleValueResolverInterface extends ValueResolverInterface
interface CompatibleValueResolverInterface extends ArgumentValueResolverInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincentLanglet isn't it the other way around?

this code gives me deprecations right now

Copy link
Member

@VincentLanglet VincentLanglet Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try

if (interface_exists(ArgumentValueResolverInterface::class) && !interface_exists(ValueResolverInterface::class)) {
    /** @internal */
    interface CompatibleValueResolverInterface extends ArgumentValueResolverInterface
    {
    }
} else {
    /** @internal */
    interface CompatibleValueResolverInterface extends ValueResolverInterface
    {
    }
}

?

If it works for you PR is welcome

Copy link
Contributor

@Hanmac Hanmac Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Question is more about what to do between the versions:

  • 3.1.0 - 6.2.0 there was only ArgumentValueResolverInterface
  • 6.2.0 - 7.0.0 there are both ArgumentValueResolverInterface and ValueResolverInterface, the first one is deprecated.
  • 7.0.0 - there is only ValueResolverInterface

what would be the right choice for 6.2.0 - 7.0.0 ? Which Interface should we extend?

there shouldn't be extra logic needed, its just ArgumentValueResolverInterface =>ValueResolverInterface

as it was before, using ValueResolverInterface if able was better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to open a pr with what you have in mind and try having a green build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work:
#8139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants