Support custom ModelManagerException messages #8141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ; can you take a look at the failing build ? |
VincentLanglet
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support custom ModelManagerException messages
Add the option of customising the message passed to the FlashBag for caught
ModelManagerExceptionby returning astring from your overridden handleModelManagerException() methods.
This is similar to what was done previously for handleModelManagerThrowable() but that code path seems to
be unreachable.
The method signature for
handleModelManagerExceptionhas had its return type removed.New tests have been added to validate the changes work as intended by way of two new controllers in the
Sonata\AdminBundle\Tests\App\Controllernamespace:CustomModelManagerThrowableMessageControllerandCustomModelManagerExceptionMessageController.I am targeting this branch, because the change addresses an apparent inability to use handleModelManagerThrowable customised message facility from #7761.
Closes #8137
Changelog
### Changed CRUDController::handleModelManagerException can now return a custom error message string for display in the flashbag instead of Sonata ones. Return type is removed from the signature