Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for default settings not working #149

Closed
dbu opened this issue May 10, 2014 · 5 comments · Fixed by #487
Closed

Configuration for default settings not working #149

dbu opened this issue May 10, 2014 · 5 comments · Fixed by #487
Labels

Comments

@dbu
Copy link
Contributor

dbu commented May 10, 2014

For SonataDoctrinePhpcrAdmin, we usually define a tree block. We define a default setting for the id value. See for example https://github.com/symfony-cmf/cmf-sandbox/blob/master/app/config/config.yml#L139

This parameter is defined in the SonataBlockBundle configuration class. However, i can't find it being processed in the DI extension and it does not arrive at our TreeBlockService

@dbu dbu added the bug label May 10, 2014
@rmsint
Copy link
Contributor

rmsint commented May 10, 2014

@dbu saw your note, remembered some idea that maybe could help. Could it be because the 'id' setting is already defined in the TreeBlockService as default with value "/"? And the blockcontext manager merges all settings for id were the service setting for "id" overwrites the bundle setting for the "id"? Maybe to make the bundle setting work, the service default settings can be removed and moved to the DI extension of 'SonataDoctrinePhpcrBundle and perpended as config for "SonataBlockBundle".

@dbu
Copy link
Contributor Author

dbu commented Aug 19, 2014

@rmsint but should those settings not be processed by the SonataBlockBundle? any idea why we had the idea that settings would be passed on to the block / service? i don't see why that would happen in https://github.com/sonata-project/SonataBlockBundle/blob/master/DependencyInjection/SonataBlockExtension.php

should we just configure our block service with the base path instead of hardcoding the default? however, that would mean there can be only one single block (or rather, they all have the same root path which at least would become configurable).

@rande can you help us here?

@puffinofdoom
Copy link

Has there been any progress with this?

@dbu
Copy link
Contributor Author

dbu commented Nov 11, 2015

not to my knowledge.

@jordisala1991
Copy link
Member

Maybe this PR needs to be rescued: #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants