This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
Minor composer improvements #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core23
reviewed
Feb 3, 2018
| @@ -36,7 +36,9 @@ | |||
| "jackalope/jackalope-doctrine-dbal": "^1.0", | |||
| "php-mock/php-mock": "^1.0", | |||
| "predis/predis": "^0.8 || ^1.0", | |||
| "symfony/phpunit-bridge": "^3.3.12 || ^4.0" | |||
| "symfony/console": "^2.8 || ^3.2 || ^4.0", | |||
| "symfony/framework-bundle": "^2.8 || ^3.2 || ^4.0", | |||
There was a problem hiding this comment.
Why don't we need this on the require section?
There was a problem hiding this comment.
On master it is on require-dev section already. Added here: #161. This is only used for the commands. Not sure if the intention is to have commands only optionals. With this we do not really change what gets installed, because other dependencies on require-dev already use framework-bundle.
We can maybe think if this should be required o require-dev on the pull request where we add commands as a services.
greg0ire
approved these changes
Feb 3, 2018
kunicmarko20
approved these changes
Feb 4, 2018
|
Thanks @jordisala1991 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is BC.
Subject
This bundle also needs: