This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
Optional usage of twig service #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
approved these changes
Feb 24, 2018
greg0ire
reviewed
Feb 24, 2018
| if (method_exists($baseTemplateClass, 'attachRecorder')) { | ||
| call_user_func([$baseTemplateClass, 'attachRecorder'], $this->container->get('sonata.cache.recorder')); | ||
| if (method_exists($baseTemplateClass, 'attachRecorder')) { | ||
| call_user_func([$baseTemplateClass, 'attachRecorder'], $this->container->get('sonata.cache.recorder')); |
There was a problem hiding this comment.
Please linebreak lines over 120 chars (on my phone, can't check the actual length)
There was a problem hiding this comment.
Its exactly 120 chars 😄
|
Thanks @covex-nn |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this is a patch.
See #206
Changelog
Subject
To find Twig base template class, Sonata\CacheBundle\SonataCacheBundle::boot method gets twig service from container and does not check if it exists.