Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Deprecate the bundle #289

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Deprecate the bundle #289

merged 1 commit into from
Mar 13, 2020

Conversation

VincentLanglet
Copy link
Member

Doc update

Copy link
Member

@core23 core23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincentLanglet
Copy link
Member Author

VincentLanglet commented Mar 9, 2020

@core23 What should be done ? Removing the bundle ?
sonata-project/dev-kit#617

@core23
Copy link
Member

core23 commented Mar 9, 2020

@core23 What should be done ? Removing the bundle ?
sonata-project/dev-kit#617

First of all you need to ignore the README.md file (https://github.com/sonata-project/dev-kit/blob/master/config/projects.yml#L119-L120)

@VincentLanglet
Copy link
Member Author

@core23 What should be done ? Removing the bundle ?
sonata-project/dev-kit#617

First of all you need to ignore the README.md file (https://github.com/sonata-project/dev-kit/blob/master/config/projects.yml#L119-L120)

What does it does ?
The coreBundle was directly removed sonata-project/dev-kit@85390bb#diff-70800a36c38d85e21390f3af255c8420
And you approved two of the three PR on dev-kit. Why is it different here ?

@VincentLanglet VincentLanglet merged commit 3b6e8f7 into sonata-project:3.x Mar 13, 2020
@VincentLanglet VincentLanglet deleted the patch-1 branch March 13, 2020 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants