Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping support for symfony < 3.4 #479

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Dropping support for symfony < 3.4 #479

merged 1 commit into from
Nov 17, 2019

Conversation

franmomu
Copy link
Member

Subject

This is the same thing as sonata-project/SonataAdminBundle#5733, dropping support of Symfony < 3.4 and >= 4, < 4.2

I am targeting this branch, because these changes respect BC.

Changelog

### Removed
- Support for Symfony < 3.4
- Support for Symfony >= 4, < 4.2

There are some changes that weren't marked as deprecated:

@phansys phansys added the minor label Nov 11, 2019
@franmomu franmomu mentioned this pull request Nov 11, 2019
Merged
18 tasks
OskarStark
OskarStark previously approved these changes Nov 11, 2019
View reviewed changes
tests/Controller/CategoryAdminControllerTest.php Outdated Show resolved Hide resolved
greg0ire
greg0ire previously approved these changes Nov 12, 2019
View reviewed changes
@greg0ire greg0ire merged commit 5515c15 into sonata-project:3.x Nov 17, 2019
@greg0ire
Copy link
Contributor

Thanks @franmomu !

@franmomu franmomu deleted the drop_symfony_support_less_than3_4 branch November 17, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@greg0ire greg0ire greg0ire left review comments

@OskarStark OskarStark OskarStark left review comments

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@franmomu @greg0ire @OskarStark @phansys