Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix media bundle decoupling #490

Merged
merged 1 commit into from Jan 30, 2020
Merged

Fix media bundle decoupling #490

merged 1 commit into from Jan 30, 2020

Conversation

core23
Copy link
Member

@core23 core23 commented Jan 26, 2020

Subject

This is just an other prepartion for the next major version (#196)

I am targeting this branch, because this is BC.

Changelog

### Changed
- Loading media association based on defined class

### Fixed
- Fix media bundle decoupling

@core23 core23 added the patch label Jan 26, 2020
@core23 core23 requested a review from a team January 26, 2020 11:08
@core23 core23 merged commit 06cc808 into sonata-project:3.x Jan 30, 2020
@core23 core23 deleted the fix-media-coupling branch January 30, 2020 07:28
@core23 core23 added minor and removed patch labels Jan 30, 2020
@core23
Copy link
Member Author

core23 commented Jan 30, 2020

Changed the label to minor as this is a soft BC break, if you rely on the default value

@core23 core23 mentioned this pull request Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franmomu franmomu franmomu approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@core23 @franmomu @OskarStark